fix: update architecture checks to use isFabricEnabled in RoktLayoutView iOS #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew iOS Load the legacy native view if Fabric components are not enabled.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the architecture detection logic for iOS RoktLayoutView component to use Fabric-specific checks instead of general new architecture checks. The change ensures that the legacy native view is loaded when Fabric components are not enabled, providing more granular control over component selection.
Key changes:
- Adds
isFabricEnabledutility function to detect Fabric availability - Updates RoktLayoutView iOS component to use Fabric-specific architecture detection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| js/utils/architecture.ts | Adds isFabricEnabled function that checks for nativeFabricUIManager global |
| js/rokt/rokt-layout-view.ios.tsx | Replaces isNewArchitecture import and usage with isFabricEnabled for component selection |
jamesnrokt
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Load the legacy native view if Fabric components are not enabled.
Testing Plan
Tested with RN version
0.76.9and0.79.4Master Issue
Closes https://go.mparticle.com/work/REPLACEME